Ubuntu UI Toolkit

Code review comment for lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/listItemRightClick

  1. listItemRightClick
  2. Merge into staging
Revision history for this message
Zsombor Egri (zsombi) wrote :

What is the reason you registered a 1.3 specific ListItem? You wanted to guard the availability of the popup menu in 1.2? You can do that by not having the Popup present in 1.2 directory, and check where the ListItem is used based on the theme.toolkitVersion used.

You can look after the QML file you need based on the plugin's baseUrl(). See UbuntuComponentsPlugin::pluginUrl().

review: Needs Fixing

« Back to merge proposal