> In the Animals test at the bottom, seems there is information lost
> before you had Extinct.Animals.Europe.ModernContinent: Enum and
> Extinct.Animals.Pangaea.ModernContinent: Enum.
> Now you have Extinct.Animals.ModernContinent: Enum twice
> The Europe vs Pangaea information is lost.
If filed bug 1628129 to keep track of this: basically the upcoming new format will supersede this, and it's generally going to be more robust and universal. So fixing this in the original QML-ish code would only be interesting if real code were to hit it - Ubuntu UI Toolkit, currently the only project relying on this in real life, isn't affected.
> Also in line 40 of the patch you do : QString
> newQmlType(QString(types[0]->qmlTypeName()).split("/")[1].toUtf8());.
> Are you sure there are always at least 2 items in the list after splitting the
> string?
The code has been thoroughly reviewed before with Ubuntu UI Toolkit in mind, in that sense I'm pretty confident it works in production.
> In the Animals test at the bottom, seems there is information lost Animals. Europe. ModernContinent : Enum and Animals. Pangaea. ModernContinent : Enum. Animals. ModernContinent : Enum twice
> before you had Extinct.
> Extinct.
> Now you have Extinct.
> The Europe vs Pangaea information is lost.
If filed bug 1628129 to keep track of this: basically the upcoming new format will supersede this, and it's generally going to be more robust and universal. So fixing this in the original QML-ish code would only be interesting if real code were to hit it - Ubuntu UI Toolkit, currently the only project relying on this in real life, isn't affected.
> Also in line 40 of the patch you do : QString QString( types[0] ->qmlTypeName( )).split( "/")[1] .toUtf8( ));.
> newQmlType(
> Are you sure there are always at least 2 items in the list after splitting the
> string?
The code has been thoroughly reviewed before with Ubuntu UI Toolkit in mind, in that sense I'm pretty confident it works in production.