Merge ~ubuntu-release/britney/+git/britney2-ubuntu:sru-messages-fixes into ~ubuntu-release/britney/+git/britney2-ubuntu:master
Status: | Merged | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Merged at revision: | e51cc58a2b15c88a3caacb70d9e654be310a4965 | ||||||||||||
Proposed branch: | ~ubuntu-release/britney/+git/britney2-ubuntu:sru-messages-fixes | ||||||||||||
Merge into: | ~ubuntu-release/britney/+git/britney2-ubuntu:master | ||||||||||||
Diff against target: |
315 lines (+165/-14) 2 files modified
britney2/policies/sruadtregression.py (+32/-8) tests/test_sruadtregression.py (+133/-6) |
||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ubuntu Release Team | Pending | ||
Review via email:
|
Commit message
Switch logic of detecting failures to looking for failed tests in policy_info. Explicitly list all failing tests in the bug comment. Change wording.
Description of the change
Switch logic of detecting failures to looking for failed tests in policy_info. Explicitly list all failing tests in the bug comment. Change wording.
This basically addresses all three bugs: LP: #1836932, LP: #1836931 and LP: #1836930.
My first invalid assumption of being able to use current_
Since current_
Anyway, since we're actually looking at the failed tests already, I added a change that the resulting e-mail now lists all the failing tests. And since I was modifying the comment text already, I also changed the wording slightly and linked the SRU policy document there. It's easier this way as we can edit it freely whenever we decide to change the policy.
Added tests for all cases, even for the one with the overriden policy verdict.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.