Merge lp://staging/~twom/launchpad/sometimes-mirrors-are-broken into lp://staging/launchpad
Proposed by
Tom Wardill
| Status: | Merged |
|---|---|
| Merged at revision: | 19045 |
| Proposed branch: | lp://staging/~twom/launchpad/sometimes-mirrors-are-broken |
| Merge into: | lp://staging/launchpad |
| Diff against target: |
292 lines (+127/-4) 9 files modified
lib/lp/registry/browser/configure.zcml (+7/-0) lib/lp/registry/browser/distributionmirror.py (+35/-2) lib/lp/registry/browser/tests/distributionmirror-views.txt (+27/-1) lib/lp/registry/configure.zcml (+1/-1) lib/lp/registry/errors.py (+6/-0) lib/lp/registry/interfaces/distributionmirror.py (+13/-0) lib/lp/registry/model/distributionmirror.py (+8/-0) lib/lp/registry/templates/distributionmirror-resubmit.pt (+18/-0) lib/lp/registry/tests/test_distributionmirror.py (+12/-0) |
| To merge this branch: | bzr merge lp://staging/~twom/launchpad/sometimes-mirrors-are-broken |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Colin Watson (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Add a BROKEN state for mirrors and allow them to be resubmitted
Description of the change
A mirror can be submitted for review that obviously does not work, even before probing (DNS failure, incorrect url, etc).
Currently the only option is to mark these as 'UNOFFICIAL' or they clutter the pendingreview view.
This MP adds a 'BROKEN' state, and allows the owner of the archive to resubmit the archive once it is fixed or the details edited.
To post a comment you must log in.
Revision history for this message
| Colin Watson (cjwatson) | # |
review:
Approve
Updating diff...
An updated diff will be available in a few minutes. Reload to see the changes.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This mostly looks good, but needs another pass to tighten things up.
Could you post screenshots somewhere of DistributionMir