Merge lp://staging/~tsimonq2/debian-cd/lubuntu-cosmic-changes into lp://staging/~ubuntu-cdimage/debian-cd/ubun3

Proposed by Simon Quigley
Status: Merged
Merged at revision: 1995
Proposed branch: lp://staging/~tsimonq2/debian-cd/lubuntu-cosmic-changes
Merge into: lp://staging/~ubuntu-cdimage/debian-cd/ubun3
Diff against target: 57 lines (+28/-12)
1 file modified
tools/boot/cosmic/boot-amd64 (+28/-12)
To merge this branch: bzr merge lp://staging/~tsimonq2/debian-cd/lubuntu-cosmic-changes
Reviewer Review Type Date Requested Status
Steve Langasek Needs Fixing
Adam Conrad (community) Needs Fixing
Review via email: mp+345792@code.staging.launchpad.net

This proposal supersedes a proposal from 2018-05-17.

Description of the change

On startup, Lubuntu wants to be the same as Kubuntu, in that "Try Lubuntu before installing" and "Install Lubuntu" are removed in favor of "Start Lubuntu".

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) wrote :

Would you mind switching these terrible if || || || constructions into case statements as part of this?

review: Needs Fixing
1994. By Simon Quigley

Rework 419ish to use case rather than || || ||.

Revision history for this message
Simon Quigley (tsimonq2) wrote :

.

Revision history for this message
Steve Langasek (vorlon) :
review: Needs Fixing
Revision history for this message
Simon Quigley (tsimonq2) :
1995. By Simon Quigley

Add kubuntu-plasma5 back.

Revision history for this message
Adam Conrad (adconrad) :
review: Needs Fixing
1996. By Simon Quigley

Some more adjustments from Adam's comments.

1997. By Simon Quigley

Make the code reflect the variable name.

Revision history for this message
Steve Langasek (vorlon) wrote :

requesting one minor fix again

review: Needs Fixing
1998. By Simon Quigley

Make ubuntu-mid work.

Revision history for this message
Simon Quigley (tsimonq2) wrote :

I did that, but made the ubuntu-mid case identical to the catch-all case with the exception of setting that env var.

Thanks Steve!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches