Code review comment for lp://staging/~trond-norbye/libmemcached/gcc_fix

Revision history for this message
Monty Taylor (mordred) wrote :

Overall the patch looks fine - but what is this? I don't see CC used anywhere, and in general CC is a pretty terrible name for a macro (makes me think I'm looking at a Makefile talking about the C compiler. The other definition of OPTIONSTRING seems to be doing this instead?

8 +#ifdef __sun
9 + /* For some odd reason the option struct on solaris defines the argument
10 + * as char*
11 + */
12 +#define CC char*
13 +#else
14 +#define CC const char*
15 +#endif
16 +

review: Needs Information

« Back to merge proposal