Code review comment for lp://staging/~tribaal/storm/storm-packaging-fix-python-central

Revision history for this message
Andreas Hasenack (ahasenack) wrote :

Try with this patch to disable the test suite if it's building in a ppa. I grabbed this trick from juju-deployer, which disables tests that require networking if DEB_BUILD_ARCH or TESTING_ENVIRONMENT are set.

=== modified file 'rules'
--- rules revid:<email address hidden>
+++ rules 2014-01-30 19:18:09 +0000
@@ -10,11 +10,15 @@
  rm -rf storm.egg-info

 override_dh_auto_test:
+# don't run tests if the user set nocheck
 ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
- for python in $(shell pyversions -r); do \
- $$python setup.py test; \
- $$python-dbg setup.py test; \
- done
+# don't run tests if in a ppa builder
+ ifeq (,$(DEB_BUILD_ARCH))
+ for python in $(shell pyversions -r); do \
+ $$python setup.py test; \
+ $$python-dbg setup.py test; \
+ done
+ endif
 endif

 override_dh_strip:

Watch tab/spaces above: the "ifeq" and "endif" statements use spaces, the rest uses tabs (makefile syntax).

« Back to merge proposal