Merge lp://staging/~tribaal/charm-helpers/add-documentation-to-cluster-helpers into lp://staging/charm-helpers
Proposed by
Chris Glass
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 189 | ||||
Proposed branch: | lp://staging/~tribaal/charm-helpers/add-documentation-to-cluster-helpers | ||||
Merge into: | lp://staging/charm-helpers | ||||
Diff against target: |
202 lines (+63/-30) 2 files modified
charmhelpers/contrib/hahelpers/cluster.py (+46/-13) tests/contrib/hahelpers/test_cluster_utils.py (+17/-17) |
||||
To merge this branch: | bzr merge lp://staging/~tribaal/charm-helpers/add-documentation-to-cluster-helpers | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Charles Butler (community) | Approve | ||
Review via email: mp+229197@code.staging.launchpad.net |
Description of the change
This branch makes the hahelper.cluster code a little more documented and readable by adding docstrings and renaming functions.
Old functions are left as stubs for backwards compatiblity (and print a deprecation warning).
To post a comment you must log in.
+1 LGTM, tests all pass.
Thanks for taking the time to improve the docs!
Someone from the ~charmers group will do the actual merge shortly.