Code review comment for lp://staging/~tpeeters/ubuntu-ui-toolkit/tab-page-loader

Revision history for this message
Tim Peeters (tpeeters) wrote :

I agree what the gallery is doing is not very clean.

However, with this update:
25 - width: parentNode ? parentNode.width : undefined
26 + width: parentNode ? parentNode.width - page.x : undefined
I no longer need to update the gallery.

Also, a unit test and documentation in Page.qdoc were added.

« Back to merge proposal