Merge lp://staging/~townsend/unity/fix-lp1168019 into lp://staging/unity
Proposed by
Christopher Townsend
Status: | Merged |
---|---|
Approved by: | Christopher Townsend |
Approved revision: | no longer in the source branch. |
Merged at revision: | 3478 |
Proposed branch: | lp://staging/~townsend/unity/fix-lp1168019 |
Merge into: | lp://staging/unity |
Diff against target: |
101 lines (+36/-1) 4 files modified
dash/DashView.cpp (+9/-0) tests/CMakeLists.txt (+2/-0) tests/data/unity/scopes/commands.scope (+8/-0) tests/test_dashview.cpp (+17/-1) |
To merge this branch: | bzr merge lp://staging/~townsend/unity/fix-lp1168019 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Approve | |
Brandon Schaefer (community) | Approve | ||
Review via email:
|
Commit message
Do not display the scope bar at the bottom when the Command "Lens" is opened as it's not really not a Lens/Scope.
Description of the change
= Issue =
The Command "Lens" is not really a lens and as such, the scope bar at the bottom should not be visible when the Command "Lens" is opened.
= Fix =
Add logic to detect when the command lens is opened and if so, set the scope bar to invisible.
= Test =
Add unit test to ensure that the scope bar is indeed invisible when the command lens is active.
To post a comment you must log in.
FAILED: Continuous integration, rev:3479 jenkins. qa.ubuntu. com/job/ unity-ci/ 312/ jenkins. qa.ubuntu. com/job/ unity-saucy- amd64-ci/ 201/console jenkins. qa.ubuntu. com/job/ unity-saucy- armhf-ci/ 199/console jenkins. qa.ubuntu. com/job/ unity-saucy- i386-ci/ 200/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins: 8080/job/ unity-ci/ 312/rebuild
http://