Online Accounts: GNOME Control Center

Merge lp://staging/~tintou/gnome-control-center-signon/gnome-control-center-signon-fix-label into lp://staging/gnome-control-center-signon

  1. gnome-control-center-signon-fix-label
  2. Merge into trunk
Proposed by Corentin Noël
Status: Needs review
Proposed branch: lp://staging/~tintou/gnome-control-center-signon/gnome-control-center-signon-fix-label
Merge into: lp://staging/gnome-control-center-signon
Diff against target: 12 lines (+1/-1)
1 file modified
libaccount-plugin/oauth-plugin.c (+1/-1)
To merge this branch: bzr merge lp://staging/~tintou/gnome-control-center-signon/gnome-control-center-signon-fix-label
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Needs Fixing
Review via email: mp+150609@code.staging.launchpad.net

Description of the change

I'd like to use the library on an other distribution, this fix removes the Ubuntu name from the connection Label.

To post a comment you must log in.
Revision history for this message
Alberto Mardegan (mardy) wrote :

Thanks Corentin for this!
We actually have another merge request for the same issue (see the bug I just linked to this).

I'll ping the designers and try to get an answer soon.

Reply
Revision history for this message
Alberto Mardegan (mardy) wrote :

Hi Corentin, please see the related bug report, and this other merge request addressing the same issue:
https://code.launchpad.net/~ballogy/gnome-control-center-signon/no-hardcode-ubuntu/+merge/137462

It would be great if you could coordinate with György in order not to duplicate efforts.

Reply
Revision history for this message
Alberto Mardegan (mardy) :
review: Needs Fixing
Reply

Unmerged revisions

138. By Corentin Noël

Removed the hardcoded Ubuntu on the connect label

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches