Code review comment for lp://staging/~timo-jyrinki/compiz/migrate-profile-independent

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Looking good, see my comment on IRC for changes in the packaging needed.

Other than that, just to be picky:

240 + if not client:
241 + print "WARNING: no gconf client found. No transitionning will be done"
242 + return

-> I would rather sys.exit(1) to mark it not transitionned yet.

« Back to merge proposal