unity-2d

Merge lp://staging/~tiagosh/unity-2d/fix-dash-highlights into lp://staging/unity-2d

fix-dash-highlights
Merge into trunk

Proposed by Tiago Salem Herrmann on 2012-03-01

Status:

Needs review

Proposed branch:

lp://staging/~tiagosh/unity-2d/fix-dash-highlights

Merge into:

lp://staging/unity-2d

Diff against target:

218 lines (+68/-32)

7 files modified

shell/dash/CategoryHeader.qml (+16/-1)
shell/dash/FilterLoader.qml (+20/-4)
shell/dash/FilterPane.qml (+11/-16)
shell/dash/LensButton.qml (+5/-9)
shell/dash/LensView.qml (+3/-1)
shell/dash/MultiRangeButton.qml (+12/-0)
shell/dash/TickBox.qml (+1/-1)

To merge this branch:

bzr merge lp://staging/~tiagosh/unity-2d/fix-dash-highlights

High

Won't Fix

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2012-10-15
jenkins (community)	continuous-integration		Approve on 2012-05-31
Michał Sawicz		2012-03-01	Needs Fixing on 2012-03-01
Xi Zhu		2012-03-09	Pending
Review via email: mp+95445@code.staging.launchpad.net

Description of the change

[shell][dash] add dash keyboard highlight grey rectangles + focus-follow-mouse

Revision history for this message

Michał Sawicz (saviq) wrote on 2012-03-01:

Please create a set of pre/post screenshots for design to sign off.

The effects of those changes on the filter pane don't look right to me, the arrow near "Filter results" overflows the highlight and then the highlights for section headers look skewed.

review: Needs Fixing

lp://staging/~tiagosh/unity-2d/fix-dash-highlights updated on 2012-03-01

942. By Tiago Salem Herrmann on 2012-03-01: add 1px margin to filter pane header in order to prevent the arrow to overflow the highlight
vertically center the "All" button

Revision history for this message

Tiago Salem Herrmann (tiagosh) wrote on 2012-03-01:

pre:
http://ubuntuone.com/6d2pWdu5tpYopCeRkfzXue

post:
http://ubuntuone.com/4X7zfDobwCUKDaqyXIIHyQ
http://ubuntuone.com/4myQquUZrRSykseXZQ9Yxj
http://ubuntuone.com/66iUnSONbdYmWIJ7ykarhG
http://ubuntuone.com/2FHu42U2QZ7BOM9FPB28YS
http://ubuntuone.com/5pDkQJyCePnMmzOfHHPcqi
http://ubuntuone.com/1ZbCkdf1pLsHj3ssXnLpxD

Revision history for this message

Xi Zhu (xi.zhu) wrote on 2012-04-04:

http://ubuntuone.com/4X7zfDobwCUKDaqyXIIHyQ
http://ubuntuone.com/66iUnSONbdYmWIJ7ykarhG
http://ubuntuone.com/2FHu42U2QZ7BOM9FPB28YS

The highlight of these three need to be wider, the rule is 10px away from each side, and the first one (highlight of category header) should be with 2px round corner too.

Please see the mockup below.

And highlight of content items are updated to be consistant, same mockup below.

Revision history for this message

Xi Zhu (xi.zhu) wrote on 2012-04-04:

Sorry, the mockup is attached to the original bug.

lp://staging/~tiagosh/unity-2d/fix-dash-highlights updated on 2012-04-04

943. By Tiago Salem Herrmann on 2012-04-04: merge trunk
944. By Tiago Salem Herrmann on 2012-04-04: fix margins

Revision history for this message

Tiago Salem Herrmann (tiagosh) wrote on 2012-04-04:

more screenshots:
Pre: http://ubuntuone.com/2xHChPPYI0AqYgqFd58KbC
Post: http://ubuntuone.com/6DnjBduSQtEWg8QdEmAbah

Revision history for this message

Xi Zhu (xi.zhu) wrote on 2012-04-05:

Hi, the left side is 10px which is correct, the right side is 15px now which should be 10px too :)

Revision history for this message

jenkins (martin-mrazik+qa) wrote on 2012-05-31:

PASSED: Continuous integration, rev:944
http://s-jenkins:8080/job/unity-2d-ci/9/

review: Approve (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2012-10-15:

PASSED: Continuous integration, rev:944
http://s-jenkins:8080/job/unity-2d-ci/24/
Executed test runs:
SUCCESS: http://s-jenkins:8080/job/unity-2d-ci/./distribution=precise,flavor=amd64/24/console
SUCCESS: http://s-jenkins:8080/job/unity-2d-ci/./distribution=precise,flavor=i386/24/console

review: Approve (continuous-integration)

Unmerged revisions

944. By Tiago Salem Herrmann on 2012-04-04: fix margins
943. By Tiago Salem Herrmann on 2012-04-04: merge trunk
942. By Tiago Salem Herrmann on 2012-03-01: add 1px margin to filter pane header in order to prevent the arrow to overflow the highlight
vertically center the "All" button
941. By Tiago Salem Herrmann on 2012-03-01: merge trunk
940. By Tiago Salem Herrmann on 2012-03-01: bring back the arrow
remove the lensbar highlight when not hovered
939. By Tiago Salem Herrmann on 2012-02-27: [dash] add dash keyboard highlight grey rectangles + focus-follow-mouse