Code review comment for lp://staging/~thomir-deactivatedaccount/xpathselect/trunk-extend-type-name-options

Revision history for this message
Martin Pitt (pitti) wrote :

I didn't see anything obviously wrong with this, but then again my C++ skills are largely nonexisting, and most of the syntax is totally unfamiliar to me :/ Just two small and unimportant comments. But the test case coverage of this is quite good, and I suppose you'll test it together with the AP testsuite.

« Back to merge proposal