Code review comment for lp://staging/~thomas-voss/location-service/robustify-event-propagation-in-case-of-multiple-providers-running

Revision history for this message
Alberto Mardegan (mardy) wrote :

The code looks good to me, but I feel that this makes the logic even more complicated.

I would much rather force all providers to be out of process. This would lead to a simpler design, and might also make it possible to free some memory when the GPS is not in use.

I'm approving this because code-wise it's fine, but if it were for me, I would not merge it.

review: Approve

« Back to merge proposal