Code review comment for lp://staging/~thomas-voss/location-service/expose-engine-state-information

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Hmmm, I seem to only get a PropertiesChanged signal for "State" when I disable location, no signal on enable, and no signal on active (afaict).

I'm running this on the phone:

dbus-monitor --system "interface='org.freedesktop.DBus.Properties',path=/com/ubuntu/location/Service"

I toggle the indicator switch on/off/on:

signal sender=:1.110 -> dest=(null destination) serial=559 path=/com/ubuntu/location/Service; interface=org.freedesktop.DBus.Properties; member=PropertiesChanged
   string "com.ubuntu.location.Service"
   array [
      dict entry(
         string "IsOnline"
         variant boolean true
      )
   ]
   array [
   ]
signal sender=:1.110 -> dest=(null destination) serial=561 path=/com/ubuntu/location/Service; interface=org.freedesktop.DBus.Properties; member=PropertiesChanged
   string "com.ubuntu.location.Service"
   array [
      dict entry(
         string "IsOnline"
         variant boolean false
      )
   ]
   array [
   ]
signal sender=:1.110 -> dest=(null destination) serial=562 path=/com/ubuntu/location/Service; interface=org.freedesktop.DBus.Properties; member=PropertiesChanged
   string "com.ubuntu.location.Service"
   array [
      dict entry(
         string "State"
         variant string "disabled"
      )
   ]
   array [
   ]
signal sender=:1.110 -> dest=(null destination) serial=564 path=/com/ubuntu/location/Service; interface=org.freedesktop.DBus.Properties; member=PropertiesChanged
   string "com.ubuntu.location.Service"
   array [
      dict entry(
         string "IsOnline"
         variant boolean true
      )
   ]
   array [
   ]

review: Needs Fixing

« Back to merge proposal