Code review comment for lp://staging/~thomas-voss/dbus-cpp/fix_service_and_object_lifetime

Revision history for this message
James Henstridge (jamesh) wrote :

Currently there are conflicts when merging this branch into trunk. The ones in bus.h/bus.cpp were trivial to fix so I went ahead and looked at the branch. There are also conflicts in the symbols file that need fixing.

From a dbus perspective, the changes look sensible. Switching from the raw dbus_bus_request_name() call in the Service::Service() constructor looks like it should also solve bug 1329211 too.

I'm definitely not a C++ master, but the rest of the branch looks okay. As this will require apps to be recompiled (e.g. adding a destructor to Object), I suppose it would be good to get this merged for the gcc 4.9 transition?

I'm marking this as needs fixing, but if the conflicts are addressed I'd be happy to see this merged.

review: Needs Fixing

« Back to merge proposal