Code review comment for lp://staging/~therve/storm/twisted-integration

Revision history for this message
Christopher Armstrong (radix) wrote :

[1] Why setDaemon(True)

[2] can you use underscores for DeferredStore

[3] doc for get explaining that it loads all attributes

[4] It may be useful to extend the core Store API to allow us to avoid accessing internal attributes in the wrapper. Like, for example, Store.disable_lazy_loading(). I dunno.

[5] global mapping of storm store to deferred store? maybe?

[6] Make it so that objects that came from stores which were then put back into a pool are "broken" so that any attribute access breaks in the future.

review: Abstain

« Back to merge proposal