Code review comment for lp://staging/~therve/landscape-client/resync-reboot

Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

Makes sense to me, just need some more info.

[1]

+ The "resynchronize" reactor message cause the plugin to send fresh

s/cause/causes/

(2 times)

[2]

+ def _resynchronize(self):
+ self.registry.persist.remove(self.persist_name)
+

Are we really sure that we want this for all plugins? I can't think of any bad effect, but it is probably worth double check this.

[3]

- changes = UserChanges(self._persist, self._provider)
- changes.clear()

Looking at the implementation of UserChanges.clear, it looks like this is removing behavior? Is it intended?

review: Needs Information

« Back to merge proposal