Banking Addons

Merge lp://staging/~therp-nl/banking-addons/ba70-lp1295163-refactor_period_lookup into lp://staging/banking-addons

ba70-lp1295163-refactor_period_lookup
Merge into banking-addons-70

Proposed by Stefan Rijnhart (Opener) on 2014-03-20

Status:

Merged

Approved by:

Holger Brunn (Therp) on 2014-04-07

Approved revision:

236

Merged at revision:

250

Proposed branch:

lp://staging/~therp-nl/banking-addons/ba70-lp1295163-refactor_period_lookup

Merge into:

lp://staging/banking-addons

Diff against target:

167 lines (+45/-42)

2 files modified

account_banking/account_banking.py (+44/-41)
account_banking/banking_import_transaction.py (+1/-1)

To merge this branch:

bzr merge lp://staging/~therp-nl/banking-addons/ba70-lp1295163-refactor_period_lookup

Related bugs:

Bug #1295163: Bankstatement doesn't honor the Opening/Closing Period flag	Undecided	Fix Committed
Bug #1311041: Bank Statement Manual Creation Gives error	Undecided	Confirmed

Link a bug report

Reviewer	Review Type	Date Requested	Status
Ruchir Shukla(BizzAppDev) (community)			Needs Information on 2014-04-23
Lara (Therp)	test	2014-03-20	Approve on 2014-04-02
Holger Brunn (Therp)	code review		Approve on 2014-03-31
Pedro Manuel Baeza	code review		Approve on 2014-03-20
Review via email: mp+211970@code.staging.launchpad.net

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2014-03-20:

LGTM

Regards.

review: Approve (code review)

lp://staging/~therp-nl/banking-addons/ba70-lp1295163-refactor_period_lookup updated on 2014-03-23

236. By Stefan Rijnhart (Opener) on 2014-03-23: [FIX] Workaround for lp:1296229, defaults functions are passed context
as a positional argument

Revision history for this message

Holger Brunn (Therp) (hbrunn) on 2014-03-31:

review: Approve (code review)

Revision history for this message

Lara (Therp) (lfreeke) on 2014-04-02:

review: Approve (test)

Revision history for this message

Ruchir Shukla(BizzAppDev) (ruchir.shukla) wrote on 2014-04-23:

+ except except_osv:
59 + if date:
60 + raise

This is something not needed .
as there date field is already required field for statement and statement lines .
Can you specify in which condition it will not have value date variable?

review: Needs Information

Revision history for this message

Stefan Rijnhart (Opener) (stefan-opener) wrote on 2014-04-23:

@ruchir thanks for the review! The answer to your question is: the date is not specified when called as a default function.