lp://staging/~therp-nl/banking-addons/ba70-lp1295163-refactor_period_lookup

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/banking-addons at revision 250

Ruchir Shukla(BizzAppDev) (community): Needs Information on 2014-04-23

Lara (Therp): Approve (test) on 2014-04-02

Holger Brunn (Therp): Approve (code review) on 2014-03-31

Pedro Manuel Baeza: Approve (code review) on 2014-03-20

Diff: 167 lines (+45/-42)

2 files modified

account_banking/account_banking.py (+44/-41)
account_banking/banking_import_transaction.py (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1295163: Bankstatement doesn't honor the Opening/Closing Period flag	Undecided	Fix Committed
Bug #1311041: Bank Statement Manual Creation Gives error	Undecided	Confirmed

Link a bug report

Related blueprints

236. By Stefan Rijnhart (Opener) on 2014-03-23

[FIX] Workaround for lp:1296229, defaults functions are passed context
 as a positional argument

235. By Stefan Rijnhart (Opener) on 2014-03-20

[RFR] Unify _get_period methods on statement and statement line. As a result,
      always return a non-opening period. Small API change:
      date is always passed as argument, not in context.
[RFR] Override of _check_company_id (unrelated to the fix):
      Don't call super, but integrate its check (while being tolerant when
      there is no period).
      Refresh statement so as not to overwrite the period for every line
[RFR] PEP8 in affected code and unrelated _get_period method on voucher
      Remove obsolete class instantiations

234. By Stefan Rijnhart (Opener) on 2014-03-17

Splitting off the online account number (i.e. IBAN) lookup functionality into a separate module

233. By Stefan Rijnhart (Opener) on 2014-03-13

[IMP] Update coding standards and version of shortcut module
[IMP] Add explaining comment for recent change

232. By Launchpad Translations on behalf of banking-addons-team on 2014-03-08

Launchpad automatic translations update.

231. By Holger Brunn (Therp) on 2014-03-06

[ADD] generic addon for MT940 parsing
[ADD] ING NL implementation of MT940

230. By Stefan Rijnhart (Opener) on 2014-03-03

[FIX] Always show the statement line date in the standalone statement
line tree view

229. By Ignacio Ibeas (www.acysos.com) on 2014-03-01

Add the party identifier support for Spain.

228. By Ruchir Shukla(BizzAppDev) on 2014-03-01

[FIX] lp:1266890, journal account can still be modified when the one
 from the registered match is leading or when the move line has
 already been created.

227. By Stéphane Bidoul (Acsone) on 2014-03-01

[RFR] Refactoring of direct debit to pull less dependencies.

Result of a sprint with Akexis de Lattre in a corridor at Fosdem 2014.

In a nutshell, this MP moves the hooks that are necessary for account_direct_debit from account_banking_payment to account_banking_payment_export, resulting in a leaner dependency graph [1].

account_banking_payment (and thus account_banking core) is therefore not necessary anymore for doing direct debit.
account_banking_payment can now be seen as providing two essential functions:
1/ adding the notion of transfer account on payment modes (marking the invoices paid as soon as the payment order is sent)
2/ bridging with the bank statement reconciliation features of account_banking core

IMO, the next step in the refactoring process would be to move 1/ to a stand-alone module.

Other things in this branch:
- removing auto_install=True that we found unnecessary and potentially risky
- demo data by Alexis
- a trivial bug fix
- setting noupdate=1 for the SEPA payment mode types
- allow payment of customer refunds lp:1275478