Unity

Merge lp://staging/~themuso/unity/report-launcher-icon-quirk-state-to-screen-reader-users into lp://staging/unity

  1. report-launcher-icon-quirk-state-to-screen-reader-users
  2. Merge into trunk
Proposed by Luke Yelavich
Status: Merged
Approved by: Brandon Schaefer
Approved revision: no longer in the source branch.
Merged at revision: 3717
Proposed branch: lp://staging/~themuso/unity/report-launcher-icon-quirk-state-to-screen-reader-users
Merge into: lp://staging/unity
Diff against target: 187 lines (+67/-7)
5 files modified
launcher/ApplicationLauncherIcon.cpp (+2/-0)
launcher/LauncherIcon.cpp (+2/-0)
launcher/LauncherIcon.h (+3/-0)
plugins/unityshell/src/unity-launcher-icon-accessible.cpp (+59/-7)
po/POTFILES.in (+1/-0)
To merge this branch: bzr merge lp://staging/~themuso/unity/report-launcher-icon-quirk-state-to-screen-reader-users
Reviewer Review Type Date Requested Status
Brandon Schaefer (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+210364@code.staging.launchpad.net

Commit message

Present a textual description of the state of applications to screen reader users when navigating the launcher.

Description of the change

Present a textual description of the state of applications to screen reader users when navigating the launcher.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:3703
http://jenkins.qa.ubuntu.com/job/unity-ci/785/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/321
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/317/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/319/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/785/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3705
http://jenkins.qa.ubuntu.com/job/unity-ci/790/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/326
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/322
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/324

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/790/rebuild

review: Approve (continuous-integration)
Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Hmm im not 100% sure what the expected behavior is, what I get is:

Mouse over an icon:
Says: "Window"

Mouse over a new icon:
Says: "Window"

Clicking on an icons:
Says nothing on some windows, other windows says the title text.

If this is expected, then it looks good to me :).

Revision history for this message
Luke Yelavich (themuso) wrote :

This is not for mouse navigatino, this is for keyboard navigation, which is all that concerns screen reader users. What you described would happen with unity as it is now, even without my branch.

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

That makes much more sense. Let me re-test it :). Thanks for the clarification.

Revision history for this message
Brandon Schaefer (brandontschaefer) wrote :

Awesome works like a charm :).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.