Luke, Ted told me you didn't want to merge this in before you got other pieces. So, what is blocking this? I have a branch (https://code.launchpad.net/~rodrigo-moya/unity/indicators-a11y/+merge/48943) that is missing something like this to provide a good description for the indicator objects.
Some comments though:
The get_accessible_name seems to be related to the IndicatorObject, not the IndicatorObjectEntry's, so why do you have this:
62 struct _IndicatorObjectEntry { 63 GtkLabel * label; 64 GtkImage * image; 65 GtkMenu * menu; 66 + gchar * accessible_name; 67 };
wouldn't it be better to just have a indicator_object_get_accessible_name function for the IndicatorObject? Also, maybe just call it get_description, instead of get_accessible_name?
« Back to merge proposal
Luke, Ted told me you didn't want to merge this in before you got other pieces. So, what is blocking this? I have a branch (https:/ /code.launchpad .net/~rodrigo- moya/unity/ indicators- a11y/+merge/ 48943) that is missing something like this to provide a good description for the indicator objects.
Some comments though:
The get_accessible_name seems to be related to the IndicatorObject, not the IndicatorObject Entry's, so why do you have this:
62 struct _IndicatorObjec tEntry {
63 GtkLabel * label;
64 GtkImage * image;
65 GtkMenu * menu;
66 + gchar * accessible_name;
67 };
wouldn't it be better to just have a indicator_ object_ get_accessible_ name function for the IndicatorObject? Also, maybe just call it get_description, instead of get_accessible_ name?