Code review comment for lp://staging/~theiw/txstatsd/txstatsd-fix-871820

Revision history for this message
Lucio Torre (lucio.torre) wrote :

33 + raise TypeError()
should carry a detailed message on the error

87 + reactor.callInThread(self.logger.info, message)
might result in log lines out of order

65 + self.message_graphite_metric.mark(1)
maybe instead of (1) we should mark with the ammount of time it has been paused?

review: Needs Fixing

« Back to merge proposal