Merge lp://staging/~thedac/charm-helpers/active-stopped-check into lp://staging/charm-helpers
Proposed by
David Ames
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 572 | ||||
| Proposed branch: | lp://staging/~thedac/charm-helpers/active-stopped-check | ||||
| Merge into: | lp://staging/charm-helpers | ||||
| Diff against target: |
51 lines (+10/-1) 2 files modified
charmhelpers/core/host.py (+4/-0) tests/core/test_host.py (+6/-1) |
||||
| To merge this branch: | bzr merge lp://staging/~thedac/charm-helpers/active-stopped-check | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alex Kavanagh (community) | Approve | ||
| charmers | Pending | ||
|
Review via email:
|
|||
Description of the change
service_running is returning false positives. Actively check for stopped messages and return False.
Serivces are actually down:
# initctl list |grep cinder-
cinder-volume stop/waiting
cinder-api stop/waiting
cinder-scheduler stop/waiting
But fall through systemv check shows them up:
# service --status-all 2>&1|grep cinder-
[ + ] cinder-api
[ + ] cinder-scheduler
[ + ] cinder-volume
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good to me.