URL Dispatcher

Merge lp://staging/~ted/url-dispatcher/check-appid-urls into lp://staging/url-dispatcher/16.10

  1. check-appid-urls
  2. Merge into trunk.16.10
Proposed by Ted Gould
Status: Merged
Approved by: Larry Price
Approved revision: 92
Merged at revision: 94
Proposed branch: lp://staging/~ted/url-dispatcher/check-appid-urls
Merge into: lp://staging/url-dispatcher/16.10
Diff against target: 51 lines (+32/-1)
2 files modified
service/dispatcher.c (+11/-1)
tests/app-id-test.cc (+21/-0)
To merge this branch: bzr merge lp://staging/~ted/url-dispatcher/check-appid-urls
Reviewer Review Type Date Requested Status
Larry Price Approve
unity-api-1-bot continuous-integration Needs Fixing
PS Jenkins bot continuous-integration Pending
Review via email: mp+302074@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-06-19.

Commit message

Check versions of appid:// urls to reduce the number of invalid appids we send to UAL

Description of the change

We end up passing the AppID down to UAL, and then we get dinged for it in the recoverable errors. Let's not have that happen, let's give them a bad URL error! Fight back!

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:90
http://jenkins.qa.ubuntu.com/job/url-dispatcher-ci/180/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/url-dispatcher-wily-amd64-ci/16
    SUCCESS: http://jenkins.qa.ubuntu.com/job/url-dispatcher-wily-armhf-ci/16
    SUCCESS: http://jenkins.qa.ubuntu.com/job/url-dispatcher-wily-i386-ci/16

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/url-dispatcher-ci/180/rebuild

review: Approve (continuous-integration)
Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:90
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/6/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/290/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/296/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/6/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Larry Price (larryprice) wrote :

Just the one inline comment.

review: Needs Information
lp://staging/~ted/url-dispatcher/check-appid-urls updated
91. By Ted Gould

Updating to current trunk

92. By Ted Gould

Combine the checks on out_appid

Revision history for this message
Ted Gould (ted) wrote :

Yeah, so I combined them to have one statement and set retval based on the value we got back.

Revision history for this message
unity-api-1-bot (unity-api-1-bot) wrote :

FAILED: Continuous integration, rev:92
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/8/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/330/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/336/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-url-dispatcher-ci/8/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Larry Price (larryprice) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches