URL Dispatcher

Merge lp://staging/~ted/url-dispatcher/check-appid-urls into lp://staging/url-dispatcher/15.10

  1. check-appid-urls
  2. Merge into trunk.15.10
Proposed by Ted Gould
Status: Superseded
Proposed branch: lp://staging/~ted/url-dispatcher/check-appid-urls
Merge into: lp://staging/url-dispatcher/15.10
Diff against target: 51 lines (+33/-0)
2 files modified
service/dispatcher.c (+12/-0)
tests/app-id-test.cc (+21/-0)
To merge this branch: bzr merge lp://staging/~ted/url-dispatcher/check-appid-urls
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Indicator Applet Developers Pending
Review via email: mp+262498@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2016-08-04.

Commit message

Check versions of appid:// urls to reduce the number of invalid appids we send to UAL

Description of the change

We end up passing the AppID down to UAL, and then we get dinged for it in the recoverable errors. Let's not have that happen, let's give them a bad URL error! Fight back!

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:90
http://jenkins.qa.ubuntu.com/job/url-dispatcher-ci/180/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/url-dispatcher-wily-amd64-ci/16
    SUCCESS: http://jenkins.qa.ubuntu.com/job/url-dispatcher-wily-armhf-ci/16
    SUCCESS: http://jenkins.qa.ubuntu.com/job/url-dispatcher-wily-i386-ci/16

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/url-dispatcher-ci/180/rebuild

review: Approve (continuous-integration)
lp://staging/~ted/url-dispatcher/check-appid-urls updated
91. By Ted Gould

Updating to current trunk

92. By Ted Gould

Combine the checks on out_appid

Unmerged revisions

92. By Ted Gould

Combine the checks on out_appid

91. By Ted Gould

Updating to current trunk

90. By Ted Gould

Attaching bug

89. By Ted Gould

Add a check for handling bad versions

88. By Ted Gould

Check to ensure that a given app id is the current version

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches