Merge lp://staging/~ted/ubuntu-system-settings/about-headers into lp://staging/ubuntu-system-settings
Proposed by
Ted Gould
Status: | Rejected |
---|---|
Rejected by: | Sebastien Bacher |
Proposed branch: | lp://staging/~ted/ubuntu-system-settings/about-headers |
Merge into: | lp://staging/ubuntu-system-settings |
Diff against target: |
43 lines (+9/-2) 2 files modified
plugins/about/DevMode.qml (+1/-0) plugins/about/PageComponent.qml (+8/-2) |
To merge this branch: | bzr merge lp://staging/~ted/ubuntu-system-settings/about-headers |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sebastien Bacher (community) | Disapprove | ||
PS Jenkins bot | continuous-integration | Needs Fixing | |
Review via email:
|
Commit message
Use the header item for the header labels
Description of the change
Was just looking at the sounds stuff, then checked a version and noticed a couple of quick fixes that could be done here. Not biggies, just making it a little easier to read and closer to the spec.
To post a comment you must log in.
FAILED: Continuous integration, rev:1136 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- ci/1653/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- utopic- touch/6010 jenkins. qa.ubuntu. com/job/ generic- mediumtests- utopic/ 4126 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- utopic- i386-ci/ 845 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- mako/5647 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- armhf/7262 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- armhf/7262/ artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 14789 jenkins. qa.ubuntu. com/job/ autopilot- testrunner- otto-utopic/ 3487 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- amd64/4463 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- utopic- amd64/4463/ artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- system- settings- ci/1653/ rebuild
http://