Code review comment for lp://staging/~ted/ubuntu-app-launch/recoverable-whoopsie

Revision history for this message
Charles Kerr (charlesk) wrote :

Very nice cleanup, I need to do this in indicator-session as well.

* I /would/ ask for a pkg-config version check as well as the one dobey suggested for debian/control, but it looks like pkg-config --modversion libwhoopsie returns 0.0.0. :|

* Minor bikeshed, it would be easier to read / less likely to break if indices renumber if you defined properties' values inline, e.g.:

const char * proeprties[] = {
    "IconValue", originalicon,
    "AppID", app_id,
    "IconPath", iconpath,
    "IconField", iconfield,
    NULL
};

review: Approve

« Back to merge proposal