Code review comment for lp://staging/~ted/ubuntu-app-launch/prestart-reshuffle

Revision history for this message
Charles Kerr (charlesk) wrote :

This refactor makes a lot of sense; the diff looks terrible in LP but since most of it is just code moving from location A to B it's actually much smaller than it seems.

Glad to see report_recoverable_problem() making it into the public API! I can remove the copy from indicator-session now.

One minor wart, in libual-test.cc, hanging the app-id caused the same strings to be replaced dozens of times... a good sign that they should be constexpr'ed or #define'ed somewhere instead. This is more bikeshed than blocker; feel free to ignore. :-)

review: Approve

« Back to merge proposal