The Sound Menu

Merge lp://staging/~ted/indicator-sound/silent-mode into lp://staging/indicator-sound/14.10

  1. silent-mode
  2. Merge into trunk.14.10
Proposed by Ted Gould
Status: Merged
Merged at revision: 457
Proposed branch: lp://staging/~ted/indicator-sound/silent-mode
Merge into: lp://staging/indicator-sound/14.10
Prerequisite: lp://staging/~ted/indicator-sound/lp1358340-greeter-data
Diff against target: 247 lines (+123/-15)
5 files modified
src/CMakeLists.txt (+4/-0)
src/accounts-service-system-sound-settings.vala (+25/-0)
src/accounts-service-user.vala (+40/-0)
src/service.vala (+45/-14)
src/sound-menu.vala (+9/-1)
To merge this branch: bzr merge lp://staging/~ted/indicator-sound/silent-mode
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ted Gould Pending
Review via email: mp+236971@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-10-02.

Commit message

Show a silent mode checkbox

Description of the change

Silent mode doesn't appear to actually do anything, and I can't figure out who should be doing something about that. But now it shows in the indicator.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:457
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/150/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-utopic-amd64-ci/17
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-utopic-armhf-ci/17
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-utopic-armhf-ci/17/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/150/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:458
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/151/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-utopic-amd64-ci/18/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/indicator-sound-utopic-armhf-ci/18/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/151/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~ted/indicator-sound/silent-mode updated
459. By Ted Gould

Update to current trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:459
http://jenkins.qa.ubuntu.com/job/indicator-sound-ci/152/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-utopic-amd64-ci/19
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-sound-utopic-armhf-ci/19
        deb: http://jenkins.qa.ubuntu.com/job/indicator-sound-utopic-armhf-ci/19/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-sound-ci/152/rebuild

review: Approve (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

There was a small CI Train wreck. The only casualty was that indicator-sound was pushed manually to the archives, which will mean this single branch needs to be merged to trunk manually when the new package has landed (currently in unapproved queue).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches