Merge lp://staging/~ted/indicator-sound/silent-mode into lp://staging/~ted/indicator-sound/lp1358340-greeter-data

Proposed by Ted Gould
Status: Superseded
Proposed branch: lp://staging/~ted/indicator-sound/silent-mode
Merge into: lp://staging/~ted/indicator-sound/lp1358340-greeter-data
Diff against target: 284 lines (+141/-17)
5 files modified
src/CMakeLists.txt (+4/-0)
src/accounts-service-system-sound-settings.vala (+25/-0)
src/accounts-service-user.vala (+40/-0)
src/service.vala (+63/-16)
src/sound-menu.vala (+9/-1)
To merge this branch: bzr merge lp://staging/~ted/indicator-sound/silent-mode
Reviewer Review Type Date Requested Status
Ted Gould Pending
Review via email: mp+236969@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2014-10-02.

Commit message

Show a silent mode checkbox and respond to state in the icon

Description of the change

Silent mode doesn't appear to actually do anything, and I can't figure out who should be doing something about that. But now it shows in the indicator and on the panel.

To post a comment you must log in.
458. By Ted Gould

Don't represent silent mode in the indicator

459. By Ted Gould

Update to current trunk

Unmerged revisions

459. By Ted Gould

Update to current trunk

458. By Ted Gould

Don't represent silent mode in the indicator

457. By Ted Gould

Build the volume control first

456. By Ted Gould

Make it a switch

455. By Ted Gould

Add a silent mode menu item

454. By Ted Gould

Pull complex logic into its own function

453. By Ted Gould

Create a silent mode action

452. By Ted Gould

Backup the properties with a local value and set the proxy

451. By Ted Gould

Use silent mode to determine the icon on the panel

450. By Ted Gould

Turn the system sound proxy into a silent mode property

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: