Merge lp://staging/~ted/indicator-appmenu/lp743404 into lp://staging/indicator-appmenu/0.3
Proposed by
Ted Gould
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 115 | ||||
| Proposed branch: | lp://staging/~ted/indicator-appmenu/lp743404 | ||||
| Merge into: | lp://staging/indicator-appmenu/0.3 | ||||
| Diff against target: |
124 lines (+45/-8) 1 file modified
src/window-menus.c (+45/-8) |
||||
| To merge this branch: | bzr merge lp://staging/~ted/indicator-appmenu/lp743404 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Conor Curran (community) | Approve | ||
| Jay Taoko (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This is bug about a signal, a signal that didn't have an object. And object that had abondoned it, and didn't bother to tell the signal. This is a sad story.
But it has a happy ending.
We've now protected that signal against objects that abondon it with further checks. We've now set up the situation so that the signals get removed when they're no longer needed. And we've delt with the reprocussions of having two places to remove the signal can cause. So in a nutshell:
We've earned the right to party.
To post a comment you must log in.
Revision history for this message
| Jay Taoko (jaytaoko) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good to me Ted