> Looks good! +1
>
> [1]
>
> +from configobj import ConfigObj
>
> We need to add a Depends entry for this in debian/control (and check that it's
> available and on all supported releases).
Done.
>
> [2]
>
> + def get_config_object(self, config_source=None):
>
> Please add a docstring and make this private, since it's not meant to be used
> by calling code.
> Looks good! +1
>
> [1]
>
> +from configobj import ConfigObj
>
> We need to add a Depends entry for this in debian/control (and check that it's
> available and on all supported releases).
Done.
> object( self, config_ source= None):
> [2]
>
> + def get_config_
>
> Please add a docstring and make this private, since it's not meant to be used
> by calling code.
Done.
> config_ source) self.get_ config_ filename( )) config_ filename( ) config_ filename( )
> [3]
>
> + if config_source:
> + config_obj = ConfigObj(
> + else:
> + config_obj = ConfigObj(
>
> Please prefer removing code duplication when instantiating objects, e.g.:
>
> filename = config_source or self.get_
> config_obj = ConfigObj(filename)
>
> or:
>
> if config_source is not None:
> filename = config_source
> else:
> filename = self.get_
> config_obj = ConfigObj(filename)
Done