Code review comment for lp://staging/~tcole/oauth/unicode-safe

Revision history for this message
Martin Pool (mbp) wrote :

At the moment you are encoding them using whatever Python's default
is. I think it would be both a bit clearer and a bit less likely to
cause confusing errors if you instead made it thing.encode('ascii',
'error') if they're really required to be always ascii safe.

« Back to merge proposal