Code review comment for lp://staging/~talkless/apparmor/fix_traceroute_tcp

Revision history for this message
intrigeri (intrigeri) wrote :

Hi Vincas! Thanks for this merge request. I could reproduce the problem it's meant to fix, and I agree it makes sense to fix it. Two request though:

1. could you please merge the 4 @{PROC} lines e.g.:

  @{PROC}/sys/net/ipv4/tcp_{ecn,sack,timestamps,window_scaling} r,

2. wrt. "deny capability net_admin": on Debian sid (traceroute 1:2.1.0-2), I can't reproduce the issue it's meant to fix; which version of traceroute and OS are you using? Any specific local configuration that might come into play?

review: Needs Fixing

« Back to merge proposal