Code review comment for lp://staging/~taihsiangho/checkbox/fix-1334224

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

FYI: I'd like to see two patches:

- rework the code to make it easier to read
- add new features

In addition to that, please use under_score naming theme for methods/functions.
Iff you want to apply those changes I can show you how to do them in git in a few minutes (hangout?) otherwise we can land it as is but I'll be just a bit more grumpy each time it happens.

For methods, please keep comments _inside_ the method, better yet, use a docstring and document what the method does, what it needs and what it produces.

So again, I'm setting this to needs fixing but if you wish we can land it as-is

review: Needs Fixing

« Back to merge proposal