Code review comment for lp://staging/~superscript18/scratch/bugfix-1390607

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Conflicts with trunk r1618 and does not compile with vala-0.28.

After fixing conflicts compiles on valac 0.28. Note careful resolving of conflict in Scratch.vala required.

Using the merged branch:

Cannot reproduce bug 1390607 in latest trunk (or in this branch).

New window on middle click on Plank icon works.

Could not reproduce crash mentioned by Dan.

See inline comment regarding unhandled errors and spelling

Needs fixing but potentially mergeable.

review: Needs Fixing

« Back to merge proposal