Systers-mailman

Merge lp://staging/~stylistica/systers/SaveEssay into lp://staging/~systers-dev/systers/development

SaveEssay
Merge into development

Proposed by Sneha Priscilla on 2012-08-04

Status:	Needs review
Proposed branch:	lp://staging/~stylistica/systers/SaveEssay
Merge into:	lp://staging/~systers-dev/systers/development
Diff against target:	106 lines (+43/-0) 3 files modified Mailman/DlistMemberships.py (+2/-0) Mailman/DlistUtils.py (+31/-0) Mailman/MailList.py (+10/-0)
To merge this branch:	bzr merge lp://staging/~stylistica/systers/SaveEssay
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Nicki Hutchens (community)	2012-08-04	Approve on 2012-08-06
Nicki Hutchens (community)	2012-08-04	Approve on 2012-08-06
Robin J	2012-08-04	Approve on 2012-08-06
Anna SdG	2012-08-04	Pending
Review via email: mp+118231@code.staging.launchpad.net

Description of the change

Storing the essays for future perusal. Includes functions for storing, removing essays in the entry table and to handle change in the email address of a member.

Revision history for this message

Sneha Priscilla (stylistica) wrote on 2012-08-04:

I've removed these 3 lines from DlistUtils.py :

       if essay == None:
            syslog('info','No essay provided')
            return None

This was mainly for my understanding.

In MailList.py

essayObj=DlistUtils.Essay(self)
essayObj.RemoveEssay(emailaddr)

a) why are these two adjacent lines at different indentation levels?

They are not at two different levels. If you browse the code in my branch --> http://bazaar.launchpad.net/~stylistica/systers/SaveEssay/view/head:/Mailman/MailList.py , they are at the same indentation. I'm not sure why the diff appears so.

b) why are you removing the essay once the person is accepted? The point of saving them was to be able to return to them after the person is a member. Or am I confused?

I'm removing the essay in the ApprovedDeleteMember function , which means the essay is removed once a member is removed from the list. We are definitely able to return them after a person is a member.

Revision history for this message

Robin J (robin-jeffries) wrote on 2012-08-06:

> I've removed these 3 lines from DlistUtils.py :
>
>
> if essay == None:
> syslog('info','No essay provided')
> return None
>
> This was mainly for my understanding.
>
> In MailList.py
>
> essayObj=DlistUtils.Essay(self)
> essayObj.RemoveEssay(emailaddr)
>
> a) why are these two adjacent lines at different indentation levels?
>
> They are not at two different levels. If you browse the code in my branch -->
> http://bazaar.launchpad.net/~stylistica/systers/SaveEssay/view/head:/Mailman/M
> ailList.py , they are at the same indentation. I'm not sure why the diff
> appears so.

You are right. Weird.
>
> b) why are you removing the essay once the person is accepted? The point of
> saving them was to be able to return to them after the person is a member. Or
> am I confused?
>
> I'm removing the essay in the ApprovedDeleteMember function , which means the
> essay is removed once a member is removed from the list. We are definitely
> able to return them after a person is a member.

Got the larger context now. It's hard reviewing from just diffs.

review: Approve

Revision history for this message

Nicki Hutchens (nhutchen) on 2012-08-06:

review: Approve

Revision history for this message

Nicki Hutchens (nhutch01) on 2012-08-06:

review: Approve

Unmerged revisions

90. By Sneha Priscilla on 2012-08-04
89. By Sneha Priscilla on 2012-08-04: cleaned up essay storage
88. By Sneha Priscilla on 2012-08-03
87. By Sneha Priscilla on 2012-08-03: Added a function to handle change of email id in essay table
86. By Sneha Priscilla on 2012-07-25: Removed fullname from the essay table
85. By Sneha Priscilla on 2012-07-25: Added spaces in the parameters for stylistical purposes
84. By Sneha Priscilla on 2012-07-13: imported DlistUtils
83. By Sneha Priscilla on 2012-07-13: Storing the essays for future perusal