Juju Charms Collection
postgresql package

Code review comment for lp://staging/~stub/charms/precise/postgresql/tests

  1. Precise Pangolin (12.04)
  2. tests
  3. Merge into trunk
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Hey Stuart, thanks for taking care of that, LGTM +1

Something for future reference, since these will be run very soon in an automated charm tester, consider creating something like 00_setup.test or 00_deps.test that is a dash script which calls sudo apt-get install for any packages that any of the test files need to run. The automated charm testing environment will run in an isolated container as a user with at least sudo privileges. Including this deps/setup test as the first to run will insure your tests run properly.

review: Approve

« Back to merge proposal