Code review comment for lp://staging/~stub/charms/precise/postgresql/integration

Revision history for this message
Charles Butler (lazypower) wrote :

Stub,

I've taken some time to re-review this branch with a mindset of "Focus on the code and verify the charm works" - And indeed. This branch of postgres fixes the upstream brokeneness that I've seen.

I'm going to tentatively approve this branch on the good faith promise that there will be an update correcting the testing story - as the PG91 tests are whats failing consistently when I test - but with the severity and longevity of this response cycle - I see value in whats here with additional work scheduled elsewhere to correct our infra problems re: testing.

Thanks again for the continued effort and work to keep the postgres charm a high quality member of the charm store.

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>, or ask a question tagged with "juju" on http://askubuntu.com.

review: Approve (deploy + code)

« Back to merge proposal