Code review comment for lp://staging/~stub/charms/precise/postgresql/integration

Stuart,

I still had test failures, which are all errors in the replication-relation-joined hook, and which doesn't appear to be directly related to a change from this set.

* Test run output: http://pastebin.ubuntu.com/8473480/
* Hook error from log: http://pastebin.ubuntu.com/8473481/

Also, while definitely not related to this change set, the tests for this charm do have some significant hurdles to passing in the automated test environment. Specifically:

* The `make test` target doesn't force the `make testdep` target, causing the `make test` target to fail if run first (which is done by the automated test runner). Once the runner manually discovers and runs 00_setup.py, the rest of the tests will fail, but `make test` will already have failed by that point. (This might be best fixed by having the runner discover and run the testdep target, though I do think it would be more intuitive to have the test target depend on the testdep target.)

* As you noted in your previous comment, the tests rely on the JUJU_REPOSITORY and SERIES (if being tested against precise) environment variables. The former may be set by the test runner, but it is unlikely that the latter will be.

* The tests for this charm require a local checkout of the postgresql-psql charm, with no fallback to installing from the store (which is what's causing this failure: http://reports.vapour.ws/charm-tests/charm-bundle-test-960-results/charm/charm-testing-aws/6).

Even though these weren't introduced with this changeset, we really need to address them to get the postgresql charm passing in the automated test environment.