Juju Charms Collection
postgresql package

Code review comment for lp://staging/~stub/charms/precise/postgresql/integration

  1. Precise Pangolin (12.04)
  2. integration
  3. Merge into trunk
Revision history for this message
Adam Israel (aisrael) wrote :

Hi Stuart,

Thanks for all your work on the Postgresql charm! I've spent some time reviewing this cumulative MP against postgresql.

I should note that the above comment from review-queue is incorrect. The results did not pass automated testing.

There were a handful of errors running make lint. I fixed those and pushed the change to my personal namespace[1].

Moving on to the integration tests[2], I was able to get 19 tests to pass, with 14 failures.

I notice that a couple of the failed tests is attempting to execute `juju run --unit postgresql/1 relation-list -r replication:168`, however, relation-list only seems to be valid within the context of hook execution.

I had a great deal more failures initially, with deploy failing. I set JUJU_REPOSITORY and those tests were able to fun.

If you think it would be useful in debugging the failed tests, I can also include any juju/machine logs.

[1] lp:~aisrael/charms/precise/postgresql/fix-lint
[2] http://pastebin.ubuntu.com/8371905/

review: Needs Fixing

« Back to merge proposal