Code review comment for lp://staging/~stub/charms/precise/postgresql/bug-1325870-syslog-port

Revision history for this message
Stuart Bishop (stub) wrote :

If 'make lint' isn't working, you need to install the dependencies. tests/00_setup.test should install them all (in particular, python-flake8 which should be the only thing needed for 'make lint' to work. The unit tests should also be fine with the dependencies installed.

The integration tests require a bootstrapped juju environment. In addition, it uses 'juju run' so you need to remove any invalid host keys from ~root/.ssh/known_hosts or tests will fail (there is a bug open on juju run and how it screws with the root users known_hosts).

You might also have luck with using 'charm test' to run everything. Unfortunately on my box, 'charm test' fails to bootstrap juju (machine-0: no kvm containers possible in all-machines.log)

« Back to merge proposal