Prometheus2 charm

Code review comment for ~stub/charm-prometheus2:fix-restarts-bug-1847472

  1. Git
  2. lp:~stub/charm-prometheus2
  3. fix-restarts-bug-1847472
  4. Merge into master
Revision history for this message
Stuart Bishop (stub) wrote :

Issuing a SIGHUP to reload is certainly worth considering, but should be implemented in a separate branch to avoid bogging this fix down.

I don't know if there is a reason it was done with restart initially, or if this is a simple case of changing the set_state('prometheus.do-restart') to set_state('prometheus.do-reload'). Other handlers already do set_state('prometheus.do-reload').

« Back to merge proposal