Code review comment for ~stub/charm-prometheus2:fix-restarts-bug-1847472

Revision history for this message
Ed Stewart (emcs2) wrote :

Thanks for this - we understand Prometheus can reload its configuration at runtime without a full restart:

If the new configuration is not well-formed, the changes will not be applied. A configuration reload is triggered by sending a SIGHUP to the Prometheus process or sending a HTTP POST request to the /-/reload endpoint (when the --web.enable-lifecycle flag is enabled). This will also reload any configured rule files.

https://prometheus.io/docs/prometheus/latest/configuration/configuration/

so curl to

localhost:9090/-/reload

... should be enough to reload the rules rather than going for a full restart.
Could this be considered please?

« Back to merge proposal