> Minor comment:
>
> std::future<void> HttpClientQt::HttpSession::get_future()
> {
> return promise_->get_future();
> }
>
> Not totally sure here, but it looks a little strange. Why is promise_ a
> shared_ptr instead of a promise? Couldn't it just be a plain promise?
>
> Marcus, you are most familiar with this code, could you cast your eye over it
> too please?
Hmmm, no idea why this was a shared_ptr. Must have been some legacy reason that I removed since. Pawel, could you change the promise_ member to a std::promise<std::string> for me please? Sorry about that :/
> Minor comment: :HttpSession: :get_future( ) ->get_future( );
>
> std::future<void> HttpClientQt:
> {
> return promise_
> }
>
> Not totally sure here, but it looks a little strange. Why is promise_ a
> shared_ptr instead of a promise? Couldn't it just be a plain promise?
>
> Marcus, you are most familiar with this code, could you cast your eye over it
> too please?
Hmmm, no idea why this was a shared_ptr. Must have been some legacy reason that I removed since. Pawel, could you change the promise_ member to a std::promise< std::string> for me please? Sorry about that :/