Merge lp://staging/~stewart/drizzle/bug492391-i_s-concurrency into lp://staging/~drizzle-trunk/drizzle/development
Status: | Superseded | ||||
---|---|---|---|---|---|
Proposed branch: | lp://staging/~stewart/drizzle/bug492391-i_s-concurrency | ||||
Merge into: | lp://staging/~drizzle-trunk/drizzle/development | ||||
Diff against target: |
172 lines (+57/-14) 3 files modified
drizzled/plugin/info_schema_table.h (+21/-3) plugin/information_engine/information_cursor.cc (+24/-8) plugin/information_engine/information_cursor.h (+12/-3) |
||||
To merge this branch: | bzr merge lp://staging/~stewart/drizzle/bug492391-i_s-concurrency | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jay Pipes (community) | Needs Fixing | ||
Review via email: mp+16935@code.staging.launchpad.net |
This proposal has been superseded by a proposal from 2010-01-11.
Unmerged revisions
- 1266. By Stewart Smith
-
need _XOPEN_SOURCE defined on Linux to get portable recursive mutex definition.
- 1265. By Stewart Smith
-
pthread.hneeds to be included in info_schema_table.h
- 1264. By Stewart Smith
-
move mutex init in InfoSchemaTable to private init() method and call from both constructors
- 1263. By Stewart Smith
-
free mutex attr before mutex. as per:
http://
docs.sun. com/app/ docs/doc/ 802-1949/ 6i5ur8qam? a=view "If a mutex is dynamically allocated and was initialized with an
attribute object, its attribute object should be freed with
pthread_mutexattr_ destroy( ) before the mutex itself is freed." - 1262. By Stewart Smith
-
Rows in the I_S plugin object make it not thread safe. Due to the way we do subselects, it's also recursive (fillTable can call fillTable).... so we have a recursive mutex.
Not the most ideal fix, but a minimal one that does actually make the code work.