Code review comment for lp://staging/~stevenk/launchpad/db-add-bprc

Revision history for this message
Stuart Bishop (stub) wrote :

BinaryPackagePath.path should be UNIQUE NOT NULL.

Shouldn't this table be called BinaryPackageReleasePath to match BinaryPackageReleaseContents?

Both columns in BinaryPackageReleaseContents should be NOT NULL.

patch-2208-76-0.sql

You likely will want this construct to ensure a path exists in the BinaryPackageReleasePaths table. This will avoid race conditions in scripts (not running in serializable isolation):

insert into binarypackagepaths (path) select 'foo' where not exists (select * from binarypackagepaths where path='foo');

review: Approve (db)

« Back to merge proposal