Merge lp://staging/~stevanr/linaro-ci-dashboard/refactor-build-list into lp://staging/linaro-ci-dashboard
Proposed by
Stevan Radaković
Status: | Merged |
---|---|
Approved by: | Stevan Radaković |
Approved revision: | 32 |
Merged at revision: | 30 |
Proposed branch: | lp://staging/~stevanr/linaro-ci-dashboard/refactor-build-list |
Merge into: | lp://staging/linaro-ci-dashboard |
Diff against target: |
200 lines (+24/-88) 6 files modified
dashboard/frontend/android_build/templates/android_loop_detail.html (+3/-13) dashboard/frontend/integration_loop/templates/integration_loop_detail.html (+3/-13) dashboard/frontend/kernel_build/templates/kernel_loop_detail.html (+3/-13) dashboard/frontend/models/json_response_mixin.py (+0/-43) dashboard/frontend/templates/build.html (+3/-0) dashboard/frontend/views/loop_build_view.py (+12/-6) |
To merge this branch: | bzr merge lp://staging/~stevanr/linaro-ci-dashboard/refactor-build-list |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Milo Casagrande (community) | Approve | ||
Linaro Infrastructure | Pending | ||
Review via email: mp+121438@code.staging.launchpad.net |
Description of the change
Refactor build list with AJAX to use templates instead of hardcoded HTML.
To post a comment you must log in.
Hello Stevan!
Thanks for fixing that!
Everything looks good to me, there is only one small thing that I find
a little bit disorienting (at least at first sight), but it is not
necessary:
On Mon, Aug 27, 2012 at 5:17 PM, Stevan Radaković contrib. auth.decorators import login_required views.generic. detail import DetailView to_response( self, context): is_ajax( ): schedule_ build() in.render_ to_response( self, build) schedule_ build() to_response( template, data, context_instance = RequestContext( self.request) )
<email address hidden> wrote:
>
> from django.
> +from django.shortcuts import render_to_response
> +from django.template import RequestContext
> from django.
>
> def render_
> if self.request.
> - build = self.object.
> - return JSONResponseMix
> + data = {
> + "build" : self.object.
> + }
> + template = "build.html"
> + return render_
> else:
> raise NotImplementedError
Can we rename the render_to_response method in JSONResponseMixin?
--
Milo Casagrande
Infrastructure Engineer
Linaro.org <www.linaro.org> │ Open source software for ARM SoCs